random cleanups #3169
Open
random cleanups #3169
+156
−219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmilos
reviewed
Feb 17, 2025
1c1dd86 to
ebd140d
Compare
src/properties.cpp
Outdated
| @@ -5033,8 +5033,8 @@ const XmpPropertyInfo* XmpProperties::propertyInfo(const XmpKey& key) { | |||
| std::string property = key.tagName(); | |||
| // If property is a path for a nested property, determines the innermost element | |||
| if (auto i = property.find_last_of('/'); i != std::string::npos) { | |||
| for (; i != std::string::npos && !isalpha(property.at(i)); ++i) { | |||
| } | |||
| while (!std::isalpha(property.at(i))) | |||
There was a problem hiding this comment.
This should probably check for \0. I agree that the previous i != std::string::npos check was wrong.
There was a problem hiding this comment.
at() here is probably wrong too.
Comment on lines
+136
to
+138
| if (!value_.empty()) { | ||
| std::copy(value_.begin(), value_.end() - 1, std::ostream_iterator<int>(os, " ")); | ||
| os << static_cast<int>(value_.back()); |
There was a problem hiding this comment.
This seems a weird way to write the code. Is it a standard idiom that I'm not familiar with? If so, please could you add a comment with a hyperlink to the relevant wikipedia page or similar?
There was a problem hiding this comment.
I don't think it's standard. The goal way to avoid a manual loop.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
These are no longer needed with modern compilers. Signed-off-by: Rosen Penev <rosenp@gmail.com>
simpler Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
std::swap was added here to avoid a use after move warning. But in reality, the second usage of object is wrong and should be changed to nullptr. Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.