feat(cli): automatically determine rpc host/port #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ae90b8 to
e0b6ee2
Compare
ghost
suggested changes
Apr 9, 2020
e0b6ee2 to
fb3ae65
Compare
Good catch, I put in a quick fix to preserve the port and host we determined to use. Thanks. |
|
I'm now getting: using this branch (when xud is running & also closed). |
sangaman
commented
Apr 15, 2020
lib/cli/command.ts
Outdated
| argv.rpcport = config.rpc.port; | ||
| argv.rpchost = config.rpc.host; | ||
|
|
||
| return new XudClient(`${argv.rpchost}}:${argv.rpcport}`, credentials); |
There was a problem hiding this comment.
Looks like I typoed an extra } here after rpchost which is why the DNS resolution failures were happening, it was trying to resolve localhost} instead of localhost. Took me a while to figure out what was going on because I could've sworn it was working for me when I had tested it then I was getting the dns error too out of the blue. Thanks for catching this @erkarl .
fb3ae65 to
69a4e66
Compare
This enhances the cli to automatically attempt to find and read from the xud configuration file to determine the port and host for the xud gRPC service based on the configured network - which determines default port numbers - or configured port if specified. This prevents the user from having to specify the rpc port on `xucli` commands when using a non-mainnet xud instance or a non-default gRPC port via the config file. Closes #1451.
69a4e66 to
2063fe0
Compare
ghost
approved these changes
Apr 15, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhances the cli to automatically attempt to find and read from the xud configuration file to determine the port and host for the xud gRPC service based on the configured network - which determines default port numbers - or configured port if specified. This prevents the user from having to specify the rpc port on
xuclicommands when using a non-mainnet xud instance or a non-default gRPC port via the config file.Closes #1451.