Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connection retries not working #698

Closed
moshababo opened this issue Nov 21, 2018 · 0 comments
Closed

connection retries not working #698

moshababo opened this issue Nov 21, 2018 · 0 comments
Assignees
@sangaman @moshababo
Labels
bug Something isn't working p2p Peer to peer networking
Milestone
1.0.0-alpha.5

Comments

@moshababo
Copy link
Collaborator

Looks like we have a problem with the connection retries -
When connecting to a node, we try various addresses. On the first address, the node expected public key is being added to pendingOutgoingConnections. if connection fails, it should be removed from there, but the current code is doing it only if handshake has completed. If not, we don't have the public key, but we should use the expected one instead.
@moshababo moshababo added bug Something isn't working p2p Peer to peer networking labels Nov 21, 2018
@moshababo moshababo mentioned this issue Nov 21, 2018
Merged
@kilrau kilrau added this to the 1.0.0-alpha.5 milestone Nov 26, 2018
sangaman pushed a commit that referenced this issue Dec 4, 2018
@moshababo @sangaman
feat(p2p): reconnect to peer after disconnection (#695)
56fa2b4 
If a peer got disconnected from us post-handshake due to stalling or
without specifying any reason, reconnect to him if we have a listening
address for him.

Closes #616. Closes #698.
sangaman added a commit that referenced this issue Jan 16, 2019
@sangaman
feat(rpc): optionally subscribe to taker swaps
388c143 
This adds an optional `include_taker` flag to the `SubscribeSwaps` rpc
call to include taker swaps resulting from `ExecuteSwap` or
`PlaceOrder`. When this flag is enabled, swap results will be
transmitted both in the response of the `ExecuteSwap` or `PlaceOrder`
call as well as via the `SubscribeSwaps` stream.

Closes #698.
@sangaman sangaman mentioned this issue Jan 16, 2019
Merged
@ghost ghost assigned sangaman Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangaman sangaman

@moshababo moshababo

Labels
bug Something isn't working p2p Peer to peer networking
Projects
None yet
Milestone
1.0.0-alpha.5
Development

No branches or pull requests
3 participants
@sangaman @moshababo @kilrau