Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement behavior for #152 disconnect package "banned" #693

Open
kilrau opened this issue Nov 19, 2018 · 4 comments
Open

Implement behavior for #152 disconnect package "banned" #693

kilrau opened this issue Nov 19, 2018 · 4 comments
Assignees
Labels
has PR issues with an open PR in progress P2 mid priority

Comments

@kilrau
Copy link
Contributor

kilrau commented Nov 19, 2018

This is an offshoot of #152 and #616 to implement the following behavior for the 'special' disconnect packet "banned"

@sangaman
Copy link
Collaborator

If we dont get any response when connecting to a peer (2nd bullet point), I think it makes to sense to keep retrying as we do currently. It could be due to a transient system or network issue.

If we get a disconnecting packet that tells us we are banned, we should stop trying to reconnect, and I think probably update the node instance in the database to not attempt to reconnect on restart (new db field would probably be needed).

If we get a disconnecting packet but it is also something transient, I figure we should keep retrying the connection as we do currently.

@kilrau
Copy link
Contributor Author

kilrau commented Nov 26, 2018

Revised description, was not clear

@kilrau kilrau changed the title Implement the behavior for #152 disconnect package "banned" Implement behavior for #152 disconnect package "banned" Dec 6, 2018
@kilrau kilrau modified the milestones: 1.0.0-alpha.6, 1.0.0-alpha.7 Dec 6, 2018
@kilrau kilrau modified the milestones: 1.0.0-alpha.7, 1.0.0-alpha.8 Jan 2, 2019
@kilrau kilrau modified the milestones: 1.0.0-alpha.8, 1.0.0-alpha.9 Jan 23, 2019
@kilrau kilrau modified the milestones: 1.0.0-alpha.10, 1.0.0-alpha.11 Feb 27, 2019
@kilrau kilrau modified the milestones: 1.0.0-alpha.11, 1.0.0-alpha.12 Mar 6, 2019
@kilrau
Copy link
Contributor Author

kilrau commented Mar 6, 2019

Who's interested in this one? @erkarl @sangaman @reliveyy

@kilrau kilrau modified the milestones: 1.0.0-sprint.12, 1.0.0-sprint.14 Apr 11, 2019
@kilrau kilrau assigned ImmanuelSegol and unassigned sangaman Apr 16, 2019
@kilrau
Copy link
Contributor Author

kilrau commented May 28, 2019

@erkarl @ImmanuelSegol is the disconnect cli command working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has PR issues with an open PR in progress P2 mid priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants