Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: support ETH and ERC20 balances #831

Closed
wants to merge 1 commit into from
Closed

test: support ETH and ERC20 balances #831

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 17, 2020

This is a test branch for ExchangeUnion/xud#2043 and should not be merged.

To test:
bash xud.sh -b feat/connext-multi-currency

The above xud PR adds support for:

  • ERC20 balances in wallet and channel

This PR does NOT include:

  • support for transferring ERC20 tokens

@ghost ghost requested a review from raladev December 17, 2020 14:42
raladev
raladev requested changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@raladev raladev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • collateralization does not work for tokens (DAI in my case), connext logs does not contain err codes, it seems like vector node just did nothing after request receiving :(
    Screenshot from 2020-12-17 22-15-31

@ghost ghost closed this Jan 13, 2021
@ghost ghost deleted the feat/connext-multi-currency branch January 13, 2021 13:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@raladev