Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use conf files #405

Open
kilrau opened this issue Apr 11, 2020 · 3 comments
Open

Don't use conf files #405

kilrau opened this issue Apr 11, 2020 · 3 comments
Labels
P3 low priority

Comments

@kilrau
Copy link
Contributor

kilrau commented Apr 11, 2020

Off-shoot from #395 (comment)

How it is:

  • we copy paste the sample conf into xud.conf on every start of container, similar we are creating a lnd.conf on testnet & mainnet and persist it all on disk
    Result: adding/changing a config parameter after first run is not possible

How it should be:

  • we start xud & lnd in containers with command line parameters only avoiding issues ignoring/overwriting changed parameters by persisting a config file
  • simplify (less scripting) setting parameters
@kilrau kilrau added the P3 low priority label Apr 11, 2020
@kilrau kilrau changed the title Don't create xud.conf within xud container unless default values have to be changed Don't use conf files May 20, 2020
@kilrau kilrau added P1 top priority and removed P3 low priority labels Aug 24, 2020
@reliveyy
Copy link
Collaborator

reliveyy commented Aug 25, 2020

What about use --xud.options '--foo bar -abc' @kilrau

@kilrau
Copy link
Contributor Author

kilrau commented Aug 25, 2020

Not sure I understand. xud-docker internally should use command line options only - lets start with lnds.

@kilrau
Copy link
Contributor Author

kilrau commented Aug 25, 2020

Current major UX problem this solves : once light mode, always light mode: #617

This is how lnd.conf looks like when trying to switch from light mode to full-mode.

rpclisten=0.0.0.0:10009
restlisten=0.0.0.0:8080
trickledelay=15000
max-cltv-expiry=5000
protocol.wumbo-channels=1

[Bitcoin]
bitcoin.active=1
bitcoin.node=neutrino

[neutrino]
neutrino.addpeer=bitcoin.michael1011.at:18333
neutrino.addpeer=btc.kilrau.com:18333

[routing]
routing.assumechanvalid=1

[Bitcoind]
bitcoind.rpchost=192.168.123.44
bitcoind.rpcuser=xu
bitcoind.rpcpass=xu
bitcoind.zmqpubrawblock=tcp://192.168.123.44:38332
bitcoind.zmqpubrawtx=tcp://192.168.123.44:38333

[autopilot]
autopilot.active=false

[tor]
tor.active=1
tor.socks=9050
tor.streamisolation=1

This was referenced Sep 14, 2020
@kilrau kilrau added P3 low priority and removed P1 top priority labels Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants