This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Checkbox / Radio: Setting checked attribute on underlying input #906 #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is working for me. I will look into it further. |
| } | ||
| this.state.checked = !this.state.checked; | ||
|
|
||
| this._toggleCheckedState(); | ||
| this.$element.trigger('change', e); |
There was a problem hiding this comment.
You might need to wrap this in the if(Boolean(e)){} check to make sure that e exists before you use it. This function can be called from JS without an event having happened...
|
@BenjaminNeilDavis Yeah, let's wrap the event in an if and clean up the comments. Great find though! |
0a46f3b to
bacd170
Compare
# The first commit's message is: Checkbox / Radio: Setting checked attribute on underlying input #906 # This is the 2nd commit message: bump dist # This is the 3rd commit message: Checkbox / Radio: Setting checked attribute on underlying input #906
bacd170 to
9a4721f
Compare
interactivellama
added a commit
that referenced
this pull request
Dec 17, 2014
…event
Checkbox / Radio: Setting checked attribute on underlying input #906. Fixes #941.
| @@ -113,15 +113,14 @@ | |||
| toggle: function(e) { | |||
| //keep event from firing twice in Chrome | |||
| if (!e || (e.target === e.originalEvent.target)) { | |||
| if(Boolean(e)){ | |||
| //stop bubbling, otherwise event fires twice in Firefox. | |||
| e.preventDefault(); | |||
There was a problem hiding this comment.
WAIT! what happened to e.preventDefault()??? This was necessary to fix Firefox firing the event twice.
There was a problem hiding this comment.
Yep, just tested, you broke Firefox. I'll fix...
interactivellama
added a commit
that referenced
this pull request
Jan 1, 2015
(refix-firefox-checkbox) fix firefox bug where checkbox appears to not... Fixes bug introduced by #939.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkbox / Radio: Setting checked attribute on underlying input #906