This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
search's cleared event is fired when field is empty #931 #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BenjaminNeilDavis
commented
Dec 10, 2014
- added an option to clear when input is empty (by default set to false)
- worked with the search / close icon to make more sense
- When already searched a value the icon turns to a x. The change i implemented is if the input value changes the icon turns back to a search icon. Before it would stay an x and would have to click enter to search a different value.
|
That third bullet is a great UX find. |
|
After I clear the field, the icon goes back to search, but when I tab back into the input field. The clear icons appears again even though the field is blank. (last frame of screen capture below, the state with the 5 sec pause).
I think tabbing or clicking back into the input should not trigger a clear icon, but remain a search icon. |
|
@BenjaminNeilDavis please update your branch so the PR can be merged. |
|
Working on the fix now...great catch |
df46fa2 to
e5de36f
Compare
Checkbox / Radio: Setting checked attribute on underlying input #906
bump dist
Checkbox / Radio: Setting checked attribute on underlying input #906
bump dist
Checkbox / Radio: Setting checked attribute on underlying input #906
Wrapping in boolean if statement and cleaning up comments.
(avoid-dupe-theads) make sure thead actually gets removed
Update to Bootstrap 3.3 #918
Change tests to use moment-with-locales.js (momen.js v2.8.x)
Checkbox / Radio: Setting checked attribute on underlying input #906
letting native date construct date
instead of moment falling back to native date
bypasses deprecated warning
fix #915
Clarifies logic that chooses how to parse dates with moment.
Add moment-with-locales to index.html
(refix-firefox-checkbox) fix firefox bug where checkbox appears to not change when clicked because it is checking and then unchecking immediately
add support for passing options to datepickers when initializing scheduler
Modifiy scheduler end/start dates to pass
moment deprecated "lang" for "locale"
assign lang to locale for moment js
Fix of search when tabbing in
e5de36f to
d1a8552
Compare
swilliamset
pushed a commit
that referenced
this pull request
Jan 5, 2015
…ed-event search's cleared event is fired when field is empty #931
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.