Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

836 button type button prevent default #837

Conversation

cmcculloh-kr
Copy link

fixes #836

@cmcculloh-kr
Copy link
Author

button without a type is type="submit" and this causes problems if your spinbox is in a form:

https://html.spec.whatwg.org/multipage/forms.html#attr-button-type

swilliamset pushed a commit that referenced this pull request Nov 7, 2014
…prevent-default

836   button type button prevent default
@swilliamset swilliamset merged commit 2a8fac7 into ExactTarget:master Nov 7, 2014
@interactivellama interactivellama added this to the 3.3.0 milestone Nov 18, 2014
@cmcculloh-kr cmcculloh-kr deleted the 836---button-type-button-prevent-default branch February 6, 2015 19:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make buttons be type button, because otherwise they are type submit and that's not good
4 participants