Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Repeater Highlighting Sorted Columns & No Tbody Dups #769

Merged
merged 2 commits into from
Oct 21, 2014

Conversation

kevinparkerson
Copy link
Contributor

accounts for issue #731 by adding "list_highlightSortedColumns" option that if set to true will highlight the entire sorted column by adding a "highlight" class to the appropriate tbody td's; also fixes issue #723 by removing tbody duplicates

kevinparkerson added 2 commits October 21, 2014 12:27
…"list_highlightSortedColumns" option that if set to true will highlight the entire sorted column by adding a "highlight" class to the appropriate tbody td's; also fixes issue #723 by removing tbody duplicates
@futuremint
Copy link
Contributor

This would require a separate Pull Request, but we need to add the list_highlightSortedColumns to the docs too.

futuremint added a commit that referenced this pull request Oct 21, 2014
…lumns

Repeater Highlighting Sorted Columns & No Tbody Dups
@futuremint futuremint merged commit 5f25941 into master Oct 21, 2014
@kevinparkerson
Copy link
Contributor Author

Made an issue for it :)

@futuremint
Copy link
Contributor

And its #773 if anyone is looking for it :)

@mbeard
Copy link
Contributor

mbeard commented Oct 21, 2014

The class "highlighted" is somewhat confusing - especially for scenarios where row selection is enabled. We should name it "sorted" instead - or something along those lines.

@kevinparkerson
Copy link
Contributor Author

I've added another issue to update, will get that in shortly.

@kevinparkerson kevinparkerson deleted the repeater-highlight-sorted-columns branch October 21, 2014 21:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants