This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
scheduler: fix monthly repeat in setValue() #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two issues I ran into today:
1. I found that it wasn't enough to merely uncheck the input elements but the label elements also had to be unchecked otherwise the visual checkboxes would not update correctly
2. When setting a month-day value, `find('.select')` was not selecting any elements. I believe the correct selector to be `.selectlist` instead since the current markup for the selectlist for `.repeat-monthly-date` does not have its own class like `byday` has `.month-day-pos` and `.month-days`.
|
Oh wow, yes, there are a few issues with that. Additionally, the "checked" attribute needs to be added / removed as necessary. Thanks for the catch! @mscdex |
kevinparkerson
pushed a commit
that referenced
this pull request
Sep 12, 2014
scheduler: fix monthly repeat in setValue()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues I ran into today:
find('.select')was not selecting any elements. I believe the correct selector to be.selectlistinstead since the current markup for the selectlist for.repeat-monthly-datedoes not have its own class likebydayhas.month-day-posand.month-days.