Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Gh1994 keyboard navigation of open empty folder in tree should work as expected #2000

Conversation

cmcculloh-kr
Copy link

@cmcculloh-kr cmcculloh-kr commented Jun 24, 2017

fixes #1994

blocked by #1996 #1998

Makes tree function as expected when navigating over open empty branches. Adds unit tests.

@interactivellama
Copy link
Contributor

interactivellama commented Jun 27, 2017

This doesn't seem to fix the empty tree node problem.

Go to http://localhost:8000/dev/staticDataTree.html Open the first one and then try to navigate it with the keyboard (that is press up from full folder). It works fine when empty folder is open and you press down.

Christopher McCulloh added 3 commits June 27, 2017 19:14
…keyboard-navigation-of-open-empty-folder-in-tree
…ee' of github.com:cormacmccarthy/fuelux into GH1994---keyboard-navigation-of-open-empty-folder-in-tree
@cmcculloh-kr
Copy link
Author

Odd. What browser are you in? Works for me.
2017-06-27 19 16 12

index.html Outdated
@@ -59,14 +59,14 @@
<div class="thin-box">
<section id="checkboxes-toggling">
<div class="checkbox">
<label class="checkbox-custom" data-initialize="checkbox" id="myCustomTogglingCheckbox1">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are being added back in.

@interactivellama
Copy link
Contributor

empty branch tree stuff is good. I was in the wrong branch, when I was testing before 😈 . Please clean up changes from other branches.

Please add links to http://localhost:8000/dev/staticDataTree.html on index.html in the tree section, so folks don't have to search for them.

@interactivellama interactivellama merged commit 90d1486 into ExactTarget:master Jun 28, 2017
@cmcculloh-kr cmcculloh-kr deleted the GH1994---keyboard-navigation-of-open-empty-folder-in-tree branch July 12, 2017 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard navigation of open empty folder in Tree
3 participants