Adds section for commonjs support #1989
Conversation
| {% highlight js %} | ||
| npm install --save-dev imports-loader | ||
| // or | ||
| yarn add --dev imports-loader |
There was a problem hiding this comment.
remove yarn reference. npm 5 essentially is yarn. we do not reference yarn elsewhere nor plan to.
There was a problem hiding this comment.
agree to disagree, but done
|
@RodEsp and anyone following #1985 please feel free to provide feedback on these instructions |
|
|
||
| {% highlight js %} | ||
| // webpack 2 config | ||
| // add as a rule to module.rule |
There was a problem hiding this comment.
Should this be added to module.rule or module.loaders?
There was a problem hiding this comment.
Oh... my bad.. webpack 2. Sorry.
Do we want to include webpack 1 instructions which would use module.loader instead though?
There was a problem hiding this comment.
I think we should push for progression. If people need to integrate with webpack 1, they can look it up?
There was a problem hiding this comment.
Yeah, sounds good to me.
We need to get devtest updated to webpack 2...
|
pulling it down locally and reading it over again and then i'll merge |
| {% endhighlight %} | ||
|
|
||
| {% highlight js %} | ||
| // webpack 2 config |
There was a problem hiding this comment.
remove reference to webpack 2
There was a problem hiding this comment.
Wait, why did we remove this?
I think it makes perfect sense to document where to place the import loader (whether it's config.rules for webpack 2 or config.loaders for webpack 1). Not everyone is a webpack expert.
There was a problem hiding this comment.
Hey @RodEsp, we deleted this for the reason of being progressive. The way that the docs state it now is, "add a rule," which references webpack 2. If someone is using webpack 1, they can easily search for a backport.
There was a problem hiding this comment.
Got ya. Thanks @vernak2539.
I guess I like to be more explicit since I probably wouldn't have realized webpack 2 was being implied just from that "add rule" before this PR. But you're right, it's not too hard to look up.
| <h4>Working with webpack</h4> | ||
|
|
||
| {% highlight js %} | ||
| npm install --save-dev imports-loader |
There was a problem hiding this comment.
remove --save-dev
new versions of npm save automagically
There was a problem hiding this comment.
they "automagically" save to dependencies, not devdeps.
And I don't think we should assume as this (below) makes no illusion to force you to npm v5
"engines": {
"node": ">=5.8.x"
},
Provides documentation for using library in commonjs build tools