Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

refactor cleanInput utility method to prevent double encoding #1980

Merged
merged 4 commits into from
Jun 19, 2017

Conversation

swilliamset
Copy link
Contributor

instead of looking for markup and sanitizing this approach looks for encoding, decodes it, and re encodes everything via jquery.

@swilliamset swilliamset requested a review from cmcculloh-kr May 22, 2017 19:11
@cmcculloh-kr cmcculloh-kr changed the title refactor cleanInput utilitiy method to prevent double encoding refactor cleanInput utility method to prevent double encoding Jun 7, 2017
@cmcculloh-kr cmcculloh-kr requested review from futuremint and removed request for cmcculloh-kr June 7, 2017 17:19
Copy link
Contributor

@futuremint futuremint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs unit tests to capture the regression that this is fixing (and also to add a little context around double encoding).

@cmcculloh-kr cmcculloh-kr modified the milestone: 3.16.1 Jun 9, 2017
@swilliamset swilliamset force-pushed the update-clean-input-utility branch from 3c05b5d to 0a30d81 Compare June 10, 2017 16:08
@swilliamset
Copy link
Contributor Author

9b12717 I hate adding dependencies explicitly for an ide but if i recall there have been other incidence of ide's not integrating with our rules so thought this would help

@futuremint futuremint merged commit 77c62fb into ExactTarget:master Jun 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants