This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
better commonjs test (clean dist, consistent test) #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed commonjs testing resource (js/npm.js) from dist folder - buld dist task no longer leaves dist/js/npm.js in zip - moved creation of resources for commonjs into prep test task - test dist task now preps for commonjs tasks and cleans up
2cd43a7 to
341d2f8
Compare
futuremint
suggested changes
Dec 15, 2016
| ['browserify:commonjs', 'dist', 'jshint', 'connect:testServer', 'qunit:noMoment', 'qunit:globals', 'qunit:dist', 'htmllint', 'resetdist']); | ||
| ['jshint', 'connect:testServer', 'qunit:noMoment', 'qunit:globals', 'test-dist', 'htmllint']); | ||
|
|
||
| grunt.registerTask('prep-commonjs-test', 'run commonjs config buiild and browserify to prep for commonjs test', |
There was a problem hiding this comment.
Typo in description buiild.
| @@ -28,7 +28,7 @@ module.exports = function(grunt) { | |||
|
|
|||
| // Full distribution task | |||
| grunt.registerTask('dist', 'Build "dist." Contributors: do not commit "dist."', | |||
| ['clean:dist', 'distcss', 'copy:fonts', 'copy:templates', 'distjs', 'commonjs', 'distzip']); | |||
| ['clean:dist', 'distcss', 'copy:fonts', 'copy:templates', 'distjs', 'distzip']); | |||
There was a problem hiding this comment.
Is the commonjs bundle used anywhere else in the dev stuff? Meaning... is it ok that we're removing it from dist completely and only running it during test?
There was a problem hiding this comment.
no it's not used elsewhere
There was a problem hiding this comment.
It's used by CommonJS users of Fuel UX and anyone that pulls in FuelUX via NPM.
futuremint
approved these changes
Dec 15, 2016
|
just wondering, if you're deleting it, will it be re-added during publishing? https://github.com/ExactTarget/fuelux/blob/master/package.json#L74 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1909