Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Update README.md #1893

Merged
merged 1 commit into from
Nov 2, 2016
Merged

Update README.md #1893

merged 1 commit into from
Nov 2, 2016

Conversation

claushellsing
Copy link
Contributor

  • Even if you have push rights, do not merge your own pull requests.
  • All PRs need to have an issue associated with them that they are responding to
  • Your PR should fix the associated issue
  • Your PR should include unit tests

Complete and delete the following checklist before issuing your pull request:

    • Limit commits to as few per pull request as sensible, so that the pull request can be focused.
    • Be intentional with PR titles
        • Use the imperative verb in commits. Preference of "adds" over "added" or "adding."
        • Capitalize the first word and any proper nouns.
        • Limit to 50 characters max.
        • Periods are not needed at the end.
          • Bad: Button group updated
          • Better: Button group font updated
          • Best: Decreases button group's large button font weight
    • Write a thorough description of your changes
        • Include fixes with the issue number to close the issue.
        • Explain why you wrote the code the way you wrote it, especially if you faced specific unique technical constraints/challenges.
        • If the code change is large, give a brief outline of the changes (ie. "Adds new functionality to handle the event listening in src/listener.js").
    • Make sure the new unit tests you wrote for this PR pass.
    • Delete this checklist.

fix typo

Copy link
Contributor

@swilliamset swilliamset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tanks

@swilliamset swilliamset merged commit 35726fd into ExactTarget:master Nov 2, 2016
@cmcculloh-kr cmcculloh-kr modified the milestones: 3.15.8, 3.15.9 Nov 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants