Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Replaces JS loader with SVG. Stubs out old JS methods #1890

Merged
merged 3 commits into from
Oct 26, 2016
Merged

Replaces JS loader with SVG. Stubs out old JS methods #1890

merged 3 commits into from
Oct 26, 2016

Conversation

cmcculloh-kr
Copy link

@cmcculloh-kr cmcculloh-kr commented Oct 26, 2016 •
edited by chriscorwin
Loading

Old:
image

New:
image

  • Pull changes
  • grunt servefast
  • Open http://localhost:8000/#loader
  • Make sure loader is working
  • Right click loader "inspect"
  • Make sure data- attribute on loader isn't firing repeatedly
  • Confirm there are no console errors related to loader
  • Review code

@cmcculloh-kr cmcculloh-kr added this to the 3.15.9 milestone Oct 26, 2016
chriscorwin
chriscorwin approved these changes Oct 26, 2016
View reviewed changes
Copy link
Contributor

@chriscorwin chriscorwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@chriscorwin chriscorwin merged commit 6c271a1 into ExactTarget:master Oct 26, 2016
@cmcculloh-kr cmcculloh-kr deleted the GH1884---use-mc-theme-svg-for-loader branch May 3, 2017 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chriscorwin chriscorwin chriscorwin approved these changes

Assignees

@chriscorwin chriscorwin

Labels
loader
Projects
None yet
Milestone
3.15.9
Development

Successfully merging this pull request may close these issues.
2 participants
@cmcculloh-kr @chriscorwin