This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Wizard should not fire stepclicked on content elements #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcculloh-kr
approved these changes
Oct 10, 2016
interactivellama
added a commit
that referenced
this pull request
Oct 11, 2016
cleans up code from recent PR #1879
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/ExactTarget/fuelux/issues/1877. This corrects Wizard stepclicked call.
I've also seen a lot of calls to steps container in the code:
It could also lead to wrong behavior depending on content.
It's better to hold it as a property of Wizard object. May I include such change in this PR?