This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Update repeater header checkbox to use correct markup #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var checkBoxMarkup = '<div class="repeater-list-heading header-checkbox">' + | ||
| '<label for="' + checkAllID + '" class="checkbox-custom checkbox-inline">' + | ||
| '<input id="' + checkAllID + '" class="sr-only" type="checkbox" value="">' + |
There was a problem hiding this comment.
According to the markup folder, the id goes on the label, not the input:
<label class="checkbox-custom checkbox-inline" data-initialize="checkbox" id="myCustomCheckbox">
<input class="sr-only" type="checkbox" value=""> <span class="checkbox-label">1</span>
</label>
There was a problem hiding this comment.
Sounds good. I knew that but was trying to make I didn't break things. Will update and test.
89b8c64 to
921f779
Compare
| '<label for="' + checkAllID + '"></label></div></div>'; | ||
|
|
||
| var checkBoxMarkup = '<div class="repeater-list-heading header-checkbox">' + | ||
| '<label id="' + checkAllID + '" class="checkbox-custom checkbox-inline">' + |
There was a problem hiding this comment.
@CormacMcCarthy Updated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, Fuel UX, old friend. It's been a while.
Partial fix to #251 in GHE's Fuel UX site. This corrects the markup generated by the repeater.
There shouldn't be any visual changes here. The main point was to wrap the
inputin thelabelto align with markup found in the Fuel UX Checkbox, so that we have the same starting point for checkboxes for the Lightning Theme.