This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1790 for @dkilgore
pageChanged.fu.repeater
should now only fire once. Repeater'spageChanged
event will now return an array with a[ [pageNumber], [dataObject] ]
shape.Additional help with paging and multiple
combobox
eventsIf repeater only has two pages of data, the combobox will be present. If a
3
is entered into the combobox the data key will return the data from the combobox'schanged
event{ notFound: true, text: '3'}
The
3
is not present (since there are only two pages), therefore anotFound
will be present in the data returned from thecombobox
. A 3 (or really a zero index 2, will still be passed into the repeater, but you can now check for thenotFound
key in order to revert to a valid page if you so choose.Combobox was refactored, so that that
changed.fu.combobox
event did not fire twice when changed after typing and then using the enter key. Issues were also present that created multiple selected menu items due to previous item with.selected
class were not being removed, but still determining what item selection by a query selector for.selected:first
.Individual tests
Individual tests for combobox were not being "taken down" and therefore tests were affecting each other and not isolated. It's a
noop/return
if you run.combobox()
on a DOM element that has already been initialized.Please note: There are combobox tests that test events fire once, but there are no tests to check that
pagechanged.fu.repeater
runs once or any tests related to that event at all.