This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Update tree markup to have alert role on span #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was erroring out for me when doing repeater/combobox fixes. |
| @@ -12,7 +12,7 @@ | |||
| </button> | |||
| </div> | |||
| <ul class="tree-branch-children" role="group"></ul> | |||
| <div class="tree-loader" role="alert">Loading...</div> | |||
| <div class="tree-loader"><span role="alert">Loading...</span></div> | |||
There was a problem hiding this comment.
You said "you can't have role="alert" on li tags" but there are also a lot of changes here on div tags too. Are you fixing more than necessary here?
There was a problem hiding this comment.
I was trying to make it consistent and always you use a span. You are right the div's don't need to change to pass.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grunt serve task was failing do to html lint errors. Apparently, you can't have alert ARIA roles on li tags. They need to be on the ul or something inside the li tag.