This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Adds ability to cancel repeater search #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,7 +76,8 @@ | |||
| this.$pageSize.selectlist(); | |||
| this.$primaryPaging.find('.combobox').combobox(); | |||
| this.$search.search({ | |||
| searchOnKeyPress: this.options.searchOnKeyPress | |||
| searchOnKeyPress: this.options.searchOnKeyPress, | |||
| allowCancel: true | |||
There was a problem hiding this comment.
This means that the search in the repeater will always be cancelable. Should we also support overriding this option on repeater for someone who does not want repeater searches to be cancelable?
There was a problem hiding this comment.
The tech specs didn't cover whether it should always be cancelable, so allowing cancels seemed the less dangerous assumption. I can definitely allow passthrough for Repeater if you'd like it to.
There was a problem hiding this comment.
Its fine for now, we'll add it later if someone asks for it to be disabled.
|
Made the requested changes. |
futuremint
added a commit
that referenced
this pull request
Mar 21, 2016
Adds ability to cancel repeater search
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1733
pendingstate to SearchallowsCanceloption to Search. Defaults toFALSEallowsCancel: TRUEsearchChangeevent to Repeater. Repeater disables Search, which with theallowsCanceloption, does not disable the button. When Repeater is finished rendering, therenderedevent is pushed to Search, removing thependingstatus and class. This returns the button to Clear functionality. If the button is pushed duringpendingstatus, thecanceledevent is pushed to Repeater. Repeater receives this event, and pushes it's own event out for the datasource to handle the cancelation of the XHR request or simply ignoring the results. Meanwhile, a render is performed and Search is cleared as normal.