This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
adds filter option to combobox and keyboard nav for dropdown #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 19, 2016 14:28
… changed event to match user intent
| autoResizeMenu: true, | ||
| filterOnKeypress: false, | ||
| showOptionsOnKeypress: false, | ||
| filter: function filter(list, predicate, self) { |
There was a problem hiding this comment.
please add a space between filter and (
|
only some minor formatting changes needed, once those are done this is good to go! 👍 |
|
Ah yes, those unit tests are nice! Good work! 👍 |
kevinparkerson
pushed a commit
that referenced
this pull request
Feb 23, 2016
…in-combobox-for-typeahead-supportfuelux adds filter option to combobox and keyboard nav for dropdown
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1710
Allows the user to provide their own filter as an option if desired (or just use the basic built-in one).
By default, could be styled to support different displays for partial or full matches if desired.
The keyboard navigation also increases accessibility for the control.
Also fixes until-know-uncaught bug where
$(a).text()contents may contain whitespace due to html formatting, and therefore"One "and"One"would not match (now calling.trim()on$(a).text())Default filter:
.text-success.text-infoCombobox now:
esc