This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Adds proper form wrapping and many missing attributes from form controls #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did we decide against the |
|
never mind. the conversation before was about an |
swilliamset
added a commit
that referenced
this pull request
Feb 18, 2016
…-element-templates-should-contain-form-group-wrappersfuelux Adds proper form wrapping and many missing attributes from form controls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1716
Form controls were missing form-group wrappers, which is a crucial component of the markup when actually trying to use the control in the context of a form (which should be a majority of use-cases).
While I was adding this I went through and added many of the missing attributes and options that were previously left out due to time constraints (when the templates were created, the decision was made to only add the attributes and options absolutely necessary for displaying the examples on the fuelux site).