This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Tree lazy loading #1720
Merged
Tree lazy loading #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 18, 2016 11:11
…and therefore leaving the posibility open for it to be re-added to jQuery's internal data array again if is called on the object (pretty likely). Assumes intent was to actually remove the attribute, and so now it does
|
from what I can tell this looks good |
| if (isBackgroundProcess === false) { | ||
| loader.removeClass('hide hidden'); // hide is deprecated | ||
| $loader.removeClass('hide hidden'); // hide is deprecated |
There was a problem hiding this comment.
Change this comment to:
//in jQuery >= v3.0 hide and show are changing behaviors
kevinparkerson
pushed a commit
that referenced
this pull request
Feb 19, 2016
…ngfuelux Tree lazy loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1708
Adds third leaf type to tree,
overflow, that displays as a link wherever it appears in the tree, with whatever name the user provides as the link text. When clicked, behaves similar to clicking on a folder, except that it also passes its data attributes back to the datasource to allow the datasource to respond appropriately. Whatever is returned by the datasource is appended to the parent branch of the clicked overflow. Overflow is removed when it is clicked.Incorporated this into the tree's handlebars template.
When adding tests I tried to filter by which items no longer had
data-templateand discovered that this attribute wasn't actually being removed (it seemed from the intent of the code that it should have been). I modified the tree code to remove this (it now runsremoveAttr("data-template")afterremoveData("template")since it could feasibly cause further problems for others if they happen to call $() on a tree leaf (which would re-add the data back into jQuery's internal data store). This allowed for more fine-grained testing as well as potentially avoiding future bugs.