This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Datepicker shows selected date when opened #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the datepicker is shown. If no selected date is present today's date is used. Also adds show and hide methods, along with 'shown' and 'hidden' events
| if (!this.$input.is(':focus')){ | ||
| this.$element.find('.input-group-btn').addClass('open'); | ||
| show: function () { | ||
| var date = (this.selectedDate) ? this.selectedDate : new Date(); |
There was a problem hiding this comment.
this.selectedDate || new Date() Or Gate
swilliamset
added a commit
that referenced
this pull request
Jan 13, 2016
…cted Datepicker shows selected date when opened
|
see https://github.com/ExactTarget/fuelux/issues/1671#issuecomment-175112271 for "enhancement" label removal |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1671 by having the calendar with the selected date visible when the datepicker is shown. If no selected date is present today's date is used.
Also adds show and hide methods, along with 'shown' and 'hidden' events. These will need to be documented.
Unit tests have been added to accompany these additions.
I've funneled all entry and exit points through the show and hide methods. I wanted to make use of
show.bs.dropdowninstead ofshown.bs.dropdown(in order to switch the calendar screen before the dropdown was made visible) but could not due to a bug with Bootstrap's dropdown (https://github.com/twbs/bootstrap/blob/master/js/dropdown.js#L80 should bereturn false;). That bug is unlikely to be fixed, soshown.bs.dropdownwill have to do. There is no visible impact anyway since the calendar screen renders very quickly (it's the same thing used when switching months)