This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Repeater sub-controls and functions now acknowledge overall disabled state #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 7, 2015 15:17
…houldn't during a disabled repeater state
|
Unit test please |
|
Dunno why the Travis build failed but: |
| @@ -286,6 +286,8 @@ | |||
|
|
|||
| //row level actions click | |||
| this.$element.find('.table-actions tbody .action-item').on('click', function(e) { | |||
| if (self.$element.hasClass('disabled')) return; | |||
There was a problem hiding this comment.
set and use self.isDisabled instead of looking at class
BenjaminNeilDavis
added a commit
that referenced
this pull request
Dec 9, 2015
…bled Repeater sub-controls and functions now acknowledge overall disabled state
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1534 by making sub-controls account for disabled state. The following items now don't work when the repeater is disabled:
.repeater-viewsradio buttonsAdditionally, I have fixed an issue where rendering a different view manually via the
rendermethod did not also change the selected view radio button :)