using css instead of outerHeight to set height

[cmcculloh-kr]

fixes #1634

Setting using .outerHeight() instead of .css({height:...}) breaks repeaters iframed in in firefox.

There is something really weird going on to where when you set using outerHeight, it takes the 12 pixels of padding and the 1 pixel of bottom border into account and changes the correct "33" to "20" and sets the css height property to 7 (because 7 + 13 pixels of calculated padding and border is 20). It's like it accounts for padding and margin coming out and going in, stripping them off twice for the final height set. This only occurs in Firefox in an iFrame, and I don't know why. But rather than spending a lot of time figuring out exactly what is happening with jQuery, I'm just switching it to use .css instead.

Tested by:

• Pointed local fuelux-site at local fuelux gh-pages and edited version of fuelux served up by local gh-pages to include this fix. Bug was no longer present.

Then, edited in Fuel UX repo and:

• Test by opening index page, viewing & scrolling repeater, resizing window, viewing & scrolling repeater. Repeater looked correct.
• Tested index dev page in Firefox (all 4 variations). Repeater looked correct.
• Tested index dev page in Chrome (all 4 variations). Repeater looked correct.
• Tested index dev page in IE 11 (all 4 variations) through BrowserStack. It had some “quirks” that were consistent with the “quirks” already present in IE 11.
• Tested index dev page in IE 10 (all 4 variations) through BrowserStack. It had some “quirks” that were consistent with the “quirks” already present in IE 10.

[futuremint]

Kevin cleaned up some of the repeater list code... might want to check this again with his latest code I just merged in.

[kevinparkerson]

@CormacMcCarthy this change should probably be very easy with the latest code, not sure why there'd be a merge conflict with this

[cmcculloh-kr]

I have to run all of my tests again now though, will comment once I've done that.

[cmcculloh-kr]

Tested everywhere again. Good to go.

[kevinparkerson]

Interesting... probably something weird going on with the jQuery code that accounts for border-box vs content-box. This fix seems to work though! thanks