This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Scheduler: Weekdays frequency should be 'weekly' instead of 'daily' #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -554,14 +554,10 @@ | |||
| } | |||
|
|
|||
| if (recur.FREQ === 'DAILY') { | |||
| if (recur.BYDAY === 'MO,TU,WE,TH,FR') { | |||
There was a problem hiding this comment.
Please allow "old API" to work here. We can add a comment:
// Weekdays should be set farther along in this conditional when frequency is `WEEKLY`, but in order to maintain backwards compatibility with an older version of `setValue` the following few lines set the UI to weekdays when frequency is `DAILY` also.
|
Please note this could be a breaking change if you are expecting the old |
|
@dkilgore Does this change of output RRULE string cause any issue with your team? |
kevinparkerson
pushed a commit
that referenced
this pull request
Dec 4, 2015
Scheduler: Weekdays frequency should be 'weekly' instead of 'daily'
|
All checks out! Thanks @nmerchant |
interactivellama
added a commit
to interactivellama/fuelux
that referenced
this pull request
Dec 28, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting 'Weekdays' as the repeat option of the scheduler control, the recurrencePattern is as follows:
FREQ=DAILY;BYDAY=MO,TU,WE,TH,FR;INTERVAL=1when it should be:
FREQ=WEEKLY;BYDAY=MO,TU,WE,TH,FR;INTERVAL=1This can be verified against the recurrencePattern that gets set if you choose 'Weekly' as the repeat option, and manually select each week day, as these are functionally identical.