This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Repeater Resize Improvement #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uding frozen and action) instead of re-rendering. Related to issues 1568 & 1569
| this.$element.find('.repeater-header').outerHeight() - | ||
| this.$element.find('.repeater-footer').outerHeight() - | ||
| ((viewportMargins.bottom === 'auto') ? 0 : parseInt(viewportMargins.bottom, 10)) - | ||
| ((viewportMargins.top === 'auto') ? 0 : parseInt(viewportMargins.top, 10)); |
There was a problem hiding this comment.
This giant expression needs to be broken out into clarifying variables. The rewrite code that you delete was much easier to read and this needs to be unpacked the same way.
added 2 commits
November 25, 2015 09:27
futuremint
added a commit
that referenced
this pull request
Nov 25, 2015
Repeater Resize Improvement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issues with repeater resizing by simply resizing columns (including frozen and action) instead of re-rendering. Related to issues 1568 & 1569