This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Allow target in dropdown auto-flip to be window #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee83e96 to
84763e3
Compare
|
Reconsider with less condition nesting |
84763e3 to
d66ad21
Compare
|
Updated with flatter decision tree @futuremint @swilliamset |
| var noTargetChosen = targetSelector !== 'window' && !targetSelector; | ||
|
|
||
| if (nonWindowTargetChosen) { | ||
| targetedElement = $(targetSelector); |
There was a problem hiding this comment.
Is this an accidental global?
There was a problem hiding this comment.
I was just going to comment on this... @interactivellama, when I run grunt test jshint catches this and says it is undefined
d66ad21 to
9f4703f
Compare
swilliamset
added a commit
that referenced
this pull request
Nov 10, 2015
Allow window override in dropdown auto-flip
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows explicitly setting auto-flip container to window via
data-target=window.