This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Add refreshFolder method to tree #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1547ef6 to
daa98a6
Compare
| var $treebranch = $el.closest('.tree-branch'); | ||
| var $refreshedBranch; | ||
| $treebranch.find('.tree-branch-children').eq(0).empty(); | ||
| $refreshedBranch = this._discloseFolder($el.find('.tree-branch-header')); |
There was a problem hiding this comment.
Don't need to actually open the folder. Just need to refresh the content in the folder. so just empty and run populate?
There was a problem hiding this comment.
We may want to force open because of our "Loading..." pattern.
- adds isBackgroundProcess parameter to populate
daa98a6 to
0d45e3e
Compare
swilliamset
added a commit
that referenced
this pull request
Nov 3, 2015
Add refreshFolder method to tree
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refreshFoldermethod in order to bust "DOM cached" folder children and reload fromdataSource.id.Fixes #1592.
UI pattern update
refreshFolderis a background process, not something initiated by the user-- therefore "Loading..." will not display when folder is refreshed when closed.@jamin-hall Might want to check on this when you return.
Side note: We may want to wait until the data is loaded from the server to actually empty out the folder if "loading..." is not present (this would remove the "broken state" possibility.