Fixes disabling of selectable / multi select / actions #1538
Conversation
| @@ -594,6 +594,7 @@ | |||
| if (sortable) { | |||
| $both.addClass('sortable'); | |||
| $div.on('click.fu.repeaterList', function () { | |||
| if(self.isDisabled) return; | |||
There was a problem hiding this comment.
this is technically correct, but as per our style guide we are supposed to write it as follows:
if (self.isDisabled) { return; }
|
Looks good outside minor style guide compliance changes! 👍 |
|
@BenjaminNeilDavis looks like there is an issue with the unit tests: https://travis-ci.org/ExactTarget/fuelux/builds/81997536#L519 Can you please fix? |
f5a1f39 to
bb5b523
Compare
|
https://github.com/cormacmccarthy/fuelux/tree/BenjaminNeilDavis-issue-1534-diable-repeater I've updated the syntax of your async tests @BenjaminNeilDavis. However, there is still some sort of race condition keeping your tests from completing consistently and therefore when run in the context of all tests it fails (however, when run alone, it succeeds). You can check the tests locally by running |
Fixes #1534