This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Fix width when using images within selectlist #1537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please ensure that this fix is actual and not probable. Once you're sure this is the fix, we'll review it. |
|
hold until full validation as suggested by woodward above |
|
Selectlist resizes vertically as well as horizontally. @jamin-hall is this desired? Or should it be vertically static? |
|
Needs some vertical alignment love (see screenshot above). Please correct and then feel free to re-open pull request once it is ready. Once this is fixed, we will need to open a ticket in MC Theme to prevent vertical growth (in Fuel UX we want it to grow vertically, but, per @jamin-hall we don't want that to occur in MC Theme) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My terminal is borked so you'll have to check the solution, but I just did what you suggested in the issue thread #1463