This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Picker #1518
Merged
Picker #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
September 15, 2015 12:13
…ggered by other elements
…ield being different from trigger. Removes extraneous functions and options
| @@ -242,7 +242,7 @@ | |||
|
|
|||
| this.$field.val(val); | |||
|
|
|||
| if (!suppressEllipsis && !_isShown) { | |||
| if (!suppressEllipsis && !_isShown(this)) { | |||
There was a problem hiding this comment.
Is this change relevant to the Picker?
|
|
||
| var _showAbove = function _showAbove(picker) { | ||
| picker.$popup.css('height', (picker.options.height)?picker.options.height : DEFAULT_HEIGHT + 'px'); | ||
| picker.$body.css('height', ((picker.options.height)?picker.options.height : DEFAULT_HEIGHT) - 73 + 'px'); |
There was a problem hiding this comment.
What is "73" here? The answer to the life, the universe, and everything?
added 6 commits
September 17, 2015 15:36
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.