-
Notifications
You must be signed in to change notification settings - Fork 1k
Make timezone return all jQuery data instead of just select values #1468
Make timezone return all jQuery data instead of just select values #1468
Conversation
name: timeZone.name, | ||
offset: timeZone.offset | ||
}, | ||
timeZone: timezone, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking through this file I don't see where timezone
(all lower case is being set). Please confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's it. Just a typo, should be timeZone
.
Don't forget about |
This should not affect setValue. We aren't actually changing the API, all we are doing is allowing the dev access to data items they set on the value the user selected. This lets them do something like (contrived example) |
If I want to set the timezone programatically, wouldn't we want to allow the app to set the id, too? I think the app ignores the actual selectlist options and just selects whatever you feed it via |
Our official example doesn't list or support timeZoneIds. The setValue code is: Trying to add timeZoneIds to the API is well beyond the scope of the change I'm requesting. Even allowing timezone selection by any other data attribute on that field is beyond the scope of my request, although I wouldn't necessarily argue against it. It's just out of scope for what I need right now. |
We should refactor to make the |
…t-value-return-id makes timezone return all $.data() instead of just select values
fixes #1466