This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Make package version dynamic in grunt #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version set at "compile time" and updated once
|
Getting fresh package version, good. Always getting fresh package version even though you haven't changed the version especially in the score of a function, bad. Little overkill. |
|
Yes, if performance was a concern, this would not be the answer. The other option is update it at a certain point in the process, but that mean you are managing state which can easily go bad. Is this tasking running before or after the update? This makes the version stateless and always reads it from the file. |
swilliamset
added a commit
that referenced
this pull request
Aug 17, 2015
…ynamic Make package version dynamic in grunt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version set at "compile time" and updated once. Now the version is always "fresh." @swilliamset
Replaces #1445.