Add checkbox support for multi select #1407
Conversation
|
Please add example using checkbox to |
|
@interactivellama the first example will work. All that is needed is multi-select enabled. |
|
Do we want any kind of set spacing on these checkboxes?
Also, this happens on resize: |
| @@ -646,8 +648,8 @@ define(function (require) { | |||
| dataSource: function (options, callback) { | |||
| list(options, callback); | |||
| }, | |||
| list_columnSizing:false, | |||
| list_columnSyncing: false, | |||
| /* list_columnSizing:false, | |||
There was a problem hiding this comment.
Please remove comments if not needed. Same w/ line 755.
|
@BenjaminNeilDavis I think this is older code I'm referring to, but is there a reason that the action.html key is a function and not a string? Line 244: |
|
Please merge in glyphicons into actions dropdown. #1410 |
|
Are the double border line to the left side of actions column intentional? This is with column sizing on?
|
|
@interactivellama Did you do anything different to get that double line? What page are you looking at? What browser are you using? I am looking at index page in chrome and do not see that |
|
Reviewed: Assigned to @kevinparkerson for additional review. |
|
"Auto flip" of the dropdown to cause the actions dropdown to flip up has been added in this PR. It does not use |
|
@BenjaminNeilDavis It's Chrome. I think it has something to do with column sizing being on. |
|
I see nothing wrong with the code after a look at it. Would like to test it locally, but the clone download percentage is still only at 34% after 20 minutes. Slow today, for some reason. Might check it out later after it finishes. |
Added checkbox support for multi select Resolving issues found from failed test. Was not returning selected items properly Adding sort to both repeater options Fixing frozen columns, actions, multi select to work with list_columnSizing and list_columnSyncing. Fixes #1411 Repeater actions to have pointer cursor. Fixes #1311 adds checkbox support for multi select Fix broken test due to change of width property in actions option remove unneeded width property from repeater Fixes Actions function to string - removing 'multi-selected' and making everything 'selected' - removing fuelux icons from index example Found issue in test with way returning selected items. Was also selecting the frozen column since it had the selected class. Had to change to specifically look for only the main table items. Removing data-initialize of the checkboxes
bd1d5a5 to
a8a972b
Compare
|
@interactivellama and @kevinparkerson approved offline |
…port-checkbox Add checkbox support for multi select
Added checkbox support for multi select
Fixes #1311, #1421