This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Removes trailing semicolon from scheduler recurrance pattern #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@interactivellama this change looks good. I don't think it should be a big issue, but it is something that should be put in the release notes for sure |
kevinparkerson
pushed a commit
that referenced
this pull request
Jun 30, 2015
Removes trailing semicolon from scheduler recurrance pattern
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1370. However, I am unsure if this a breaking change for anyone if the semicolon is removed. I'm estimating that any library that is parsing ical recurrance pattern is using a
split(";")method and so this doesn't matter. Our unit tests however needed changing.