This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Wrap wizard steps in hidden overflow instead of entire control #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2403,7 +2405,7 @@ <h2 class="header">Year</h2> | |||
| <p>Pea horseradish azuki bean lettuce avocado asparagus okra. Kohlrabi radish okra azuki bean corn fava bean mustard tigernut jÃcama green bean celtuce collard greens avocado quandong fennel gumbo black-eyed pea. Grape silver beet watercress potato tigernut corn groundnut. Chickweed okra pea winter purslane coriander yarrow sweet pepper radish garlic brussels sprout groundnut summer purslane earthnut pea tomato spring onion azuki bean gourd. Gumbo kakadu plum komatsuna black-eyed pea green bean zucchini gourd winter purslane silver beet rock melon radish asparagus spinach. </p> | |||
| <p>Beetroot water spinach okra water chestnut ricebean pea catsear courgette summer purslane. Water spinach arugula pea tatsoi aubergine spring onion bush tomato kale radicchio turnip chicory salsify pea sprouts fava bean. Dandelion zucchini burdock yarrow chickpea dandelion sorrel courgette turnip greens. </p> | |||
| </div> | |||
| <div class="step-pane sample-pane alert-danger alert" data-step="3"> | |||
| <div class="step-pane sample-pane alert-danger alert" data-step="3" style="position: relative;"> | |||
There was a problem hiding this comment.
Move inline style to less
There was a problem hiding this comment.
Ah, this was me testing that overflow was no longer clipped via some quick inline hackery and forgetting to remove it once I was done.
|
Looks good. Please squash. |
added 2 commits
June 11, 2015 16:41
…er" wrapper around "ul.step" so that overflow: hidden is only applied to that area. Provides backwards compatability for developers using the older markup syntax.
interactivellama
added a commit
that referenced
this pull request
Jun 11, 2015
Wrap wizard steps in hidden overflow instead of entire control
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1241 by adding additional wrapper element with class
.steps-containeraround theul.steps, so thatoverflow: hiddenis only applied to that area instead of the entirewizard.This is a breaking markup change that maintains backwards compatibility by adding the class
.no-steps-containerto.wizardvia JavaScript. Please add thediv.steps-containerelement aroundul.stepsas this markup documentation when you can.for easier comparison
https://github.com/ExactTarget/fuelux/pull/1352/files?w=1