Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Remove moot version property from bower.json #1351

Merged
merged 1 commit into from
Jun 12, 2015
Merged

Remove moot version property from bower.json #1351

merged 1 commit into from
Jun 12, 2015

Conversation

kkirsche
Copy link
Contributor

@vernak2539
Copy link
Contributor

This is required for the "bower badge" in the readme file. will not remove

@vernak2539 vernak2539 closed this Jun 11, 2015
@vernak2539 vernak2539 reopened this Jun 11, 2015
@vernak2539
Copy link
Contributor

Actually,

Version badge uses GitHub tags to identify the latest Bower version. Please use Semantic Version tags to ensure proper badge function.

This is valid. not sure the bower version is used for anything

@kkirsche
Copy link
Contributor Author

It's not, hence the PR. Also just an FYI there are discussions to move bower to NPM anyway so I wouldn't really plan to support it for ever: bower/bower#1520

@kkirsche
Copy link
Contributor Author

Also their maintainer says they probably won't ever use it: http://stackoverflow.com/questions/24844901/bowers-bower-json-file-version-property

@interactivellama
Copy link
Contributor

We modify the bower.json file via the replace task in gruntFile.js at every release, so that task needs to be modified too. Also, CommonJS support (which implies full NPM/package.json) support is in the works, too.

The team is also considering moving away from Bower as a recommendation while still supporting it for the time being.

Update: I was wrong. It's updated in the bump task.

@swilliamset
Copy link
Contributor

The following line will need to be updated to no longer attempt to bump the version in the bower file

https://github.com/ExactTarget/fuelux/blob/master/Gruntfile.js#L28

@kkirsche would you be willing to update the PR

@kkirsche
Copy link
Contributor Author

@swilliamset done

@swilliamset
Copy link
Contributor

Looks like we have a conflict now. Could you rebase? If not totally understand we'll handle it. Thanks for the heads up.

@kkirsche
Copy link
Contributor Author

@swilliamset yeah it was cause you guys issued another release since this was made. I've rebased and squashed cause, well, why not

@swilliamset
Copy link
Contributor

squashes are always greatly appreciated. once travis finishes i'll be glad to merge. thanks again.

swilliamset pushed a commit that referenced this pull request Jun 12, 2015
Remove moot `version` property from bower.json
@swilliamset swilliamset merged commit f527d76 into ExactTarget:master Jun 12, 2015
@kkirsche kkirsche deleted the patch-1 branch June 12, 2015 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants