-
Notifications
You must be signed in to change notification settings - Fork 1k
Remove moot version
property from bower.json
#1351
Conversation
This is required for the "bower badge" in the readme file. will not remove |
Actually,
This is valid. not sure the bower version is used for anything |
It's not, hence the PR. Also just an FYI there are discussions to move bower to NPM anyway so I wouldn't really plan to support it for ever: bower/bower#1520 |
Also their maintainer says they probably won't ever use it: http://stackoverflow.com/questions/24844901/bowers-bower-json-file-version-property |
We modify the The team is also considering moving away from Bower as a recommendation while still supporting it for the time being. Update: I was wrong. It's updated in the bump task. |
The following line will need to be updated to no longer attempt to bump the version in the bower file https://github.com/ExactTarget/fuelux/blob/master/Gruntfile.js#L28 @kkirsche would you be willing to update the PR |
@swilliamset done |
Looks like we have a conflict now. Could you rebase? If not totally understand we'll handle it. Thanks for the heads up. |
Per bower/spec@a325da3 Remove bump task Remove bump task
@swilliamset yeah it was cause you guys issued another release since this was made. I've rebased and squashed cause, well, why not |
squashes are always greatly appreciated. once travis finishes i'll be glad to merge. thanks again. |
Remove moot `version` property from bower.json
Per bower/spec@a325da3