Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Removes 2-step build process, improve CSS/LESS debugging #1334

Merged

Conversation

interactivellama
Copy link
Contributor

Add fuelux class across LESS files. This is less DRY, but allows LESS parent selectors (&) to work properly without a two step build process like we currently have. This also also CSS source maps to work better allow debugging to actual line numbers in the source LESS. Fixes #1227.

@interactivellama interactivellama added this to the 3.8.0 milestone Jun 2, 2015
@interactivellama interactivellama changed the title Add fuelux class across files, removes 2-step LESS build Add fuelux class across LESS files, removes 2-step build Jun 2, 2015
@interactivellama interactivellama changed the title Add fuelux class across LESS files, removes 2-step build Removes 2-step build process and improves debugging Jun 2, 2015
@vernak2539
Copy link
Contributor

Just wondering, is there a reason you put did it like this for all of them

.fuelux .checkbox { ....

when you could do something more along the lines of LESS syntax like

.fuelux {
    .checkbox {
        .....

All files that were changed in this PR in multiple places would be now only changed in one spot

@interactivellama
Copy link
Contributor Author

@vernak2539 I was taking my pattern from what was completed in MC theme which was line by line, but yes, after some testing it does look like the majority of the LESS files in this repo could be wrapped. form.less is probably the heaviest user of the pseudo parent selector (&) and may need to remain "line itemized".

@interactivellama interactivellama changed the title Removes 2-step build process and improves debugging Removes 2-step build process, improve CSS/LESS debugging Jun 3, 2015
@interactivellama interactivellama force-pushed the remove-two-step-css-build branch from 50436aa to d6a2f25 Compare June 3, 2015 16:39
@interactivellama
Copy link
Contributor Author

Updated. Ignore white space: https://github.com/ExactTarget/fuelux/pull/1334/files?w=1

@vernak2539
Copy link
Contributor

@interactivellama looks good to me. a little cleaner also I feel

@swilliamset
Copy link
Contributor

extra line breaks are inconsistent. sometimes there is one after the .fuelux { line sometimes there isn't. be consistent por favor.

swilliamset pushed a commit that referenced this pull request Jun 4, 2015
Removes 2-step build process, improve CSS/LESS debugging
@swilliamset swilliamset merged commit 65f0b2e into ExactTarget:master Jun 4, 2015
@interactivellama interactivellama deleted the remove-two-step-css-build branch June 15, 2015 17:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update LESS build to have the .fuelux wrapper without the two-stage build.
3 participants