This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Make install process Windows compatible #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,7 +70,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "main": "devserver.js", | |||
| "postinstall": "./node_modules/bower/bin/bower install && tar -zcf dev/node_modules.tar.gz node_modules/;", | |||
| "postinstall": "./node_modules/bower/bin/bower install", | |||
There was a problem hiding this comment.
for it to work on windows this needs to be
"postinstall": "node ./node_modules/bower/bin/bower install",
Makes this so it only runs on Heroku and allows Windows peeps to call `bower install`
bbbf48f to
4c50b7c
Compare
|
Updated @vernak2539 . I'm sorry I didn't understand the comment. |
|
👍 |
| web: tar -zcf dev/node_modules.tar.gz node_modules/ && grunt dist && node devserver.js |
There was a problem hiding this comment.
The tar step is to insure the node_modules in the dev environment deploy quickly to heroku correct? Or is there more going on here?
|
The archive is created in order to allow TravisCI to not run It's what Bootstrap does, except they use Python and AWS. I'm just using Heroku as my AWS, because...I can. "Free Heroku" should really be listed as a dev perk on our Salesforce job posts. |
|
right on |
swilliamset
pushed a commit
that referenced
this pull request
Jun 3, 2015
Make install process Windows compatible
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move node_module archiving to Procfile
tarcommand, so it only run on Heroku, and fixes #1331 for those that run on Windows or don't havetarinstalled. It also addsnodebefore the bower command which makes it Windows compatible.