Add all release tasks to prompt menu #1328
Conversation
3c61a14 to
b7a05c5
Compare
| @@ -421,6 +444,144 @@ module.exports = function (grunt) { | |||
| } | |||
| } | |||
| }, | |||
| shell: { | |||
There was a problem hiding this comment.
move shell options into separate module. Gruntfile.js is becoming excessively large.
There was a problem hiding this comment.
I agree. I was thinking about using https://github.com/creynders/load-grunt-configs
Try debugging the lint.
Can we list the available branches to release from? |
|
please make the remote repo configurable defaulting to |
|
@cmcculloh please take a look at this branch. your insight would be helpful. |
fe39f41 to
e3c2124
Compare
|
Updated with remote repo being configurable. As to listing remotes are you thinking of running a shell command and some kind of CLI text pipe that is then parsed by JS function within the prompt? The other option would be github API, but I'm not sure that's worth the effort considering you are 90% of the time going to pulling down master to build from |
| }, | ||
| { | ||
| config: 'release.remoteRepository', | ||
| default : 'upstream', |
There was a problem hiding this comment.
Why are we repeating the defaults we set on line 44 here?
There was a problem hiding this comment.
Grunt-prompt defaults work if the user leaves the prompt blank. Even if there is a values set at the top in the release object, then an empty answer will override that and set it to empty string/undefined. The values in release could probably be removed.
There was a problem hiding this comment.
What I'm saying is, why not use grunt.config.release.remoteRepository here instead of the string "upstream"?
So:
default: grunt.config.release.remoteRepository,
|
@interactivellama let me know when you've had a chance to push an update |
e3c2124 to
42ac36e
Compare
|
Updated with lo-dash compatible template strings. @cmcculloh @swilliamset |
…ll-the-things3 Conflicts: package.json
|
Squashed and updated with master/3.8 |
|
It only crashes the release task (and the saucelabs tests if those run and the |
| default : '<%= release.remoteBaseBranch %>', | ||
| message: function() { | ||
| return 'What remote branch from ' + grunt.config('release.remoteRepository') + | ||
| ' would like to build your release based upon?'; |
There was a problem hiding this comment.
should be ' would you like to build your release based on' ?
There was a problem hiding this comment.
I'm old fashioned, I guess. 'On' is probably easier to understand in a publicly accessible repository for non-native English speakers.
|
prompts
refactor prompts to build temp branch from selected branch before prompting for next release number this will ensure the version prompt has the most accurate data also |
d8da441 to
bc2b550
Compare
|
Updated to do track remote branch first. Then look at |
|
Sorry for the confusion. Can we include the version and the timestamp in the temp release branch? Also some coloring on the yml file warning would be good. Otherwise this whole thing is a huge step forward and i'm accepting. |
Add all release tasks to prompt menu
TravisCI will fail, of course, because of the lack of
grunt-shellmodule.Originally, I had tried multiple prompts, but the idea of branching decision trees doesn't seem to work very well with the grunt structure, so instead you run
grunt release4 or 5 times--which is as close to "Edsel-like" as I think we can get.Decision tree branching is still not supported, but multiple prompts are now implemented with defaults that expect a release to be built from
masterand pushed to major release branch (3.x).Fixes #1070.