This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Add type attribute to buttons in control markup #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help prevent regression of the button type="button" bug.
| <button class="btn datepicker-wheels-back"><span class="glyphicon glyphicon-arrow-left"></span><span class="sr-only">Return to Calendar</span></button> | ||
| <button type="button" class="btn datepicker-wheels-select">Select <span class="sr-only">Month and Year</span></button> | ||
| <button type="button" class="btn datepicker-wheels-back"><span class="glyphicon glyphicon-arrow-left"></span><span class="sr-only">Return to Calendar</span></button> | ||
| <button type="button" type="button" class="btn datepicker-wheels-select">Select <span class="sr-only">Month and Year</span></button> |
There was a problem hiding this comment.
What does it mean!?! 😄
f7ceb8d to
d7ea358
Compare
|
Updated. |
swilliamset
pushed a commit
that referenced
this pull request
Jun 4, 2015
Add type attribute to buttons in control markup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer may want to review by commit due to index.html indentation.
gh-pages docs should also be audited.
Fixes #1323.