This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Do not change tree folder icons when selecting items for 3.7.x branch #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor (combine) selectFolder and selectItem to re-use code. Add clearSelected method
Many problems with this unit test: - Mouse clicks were not being tested, only API methods - Folder selectable tree needs to test items also. - Folder selectable tree needs to test items with folders previously selected, and folders with items previously selected - Markup for folder selectable tree did not include a `tree-item` template and therefore created only folders and did not create any items (hence 4 folders/items are returned instead of the folders/correct 8 items). - The selectItem method was being used to select folders.
|
There should be a third commit. "Make selectTreeNode DRY, add deselectAll method" |
01d622a to
e54a9dc
Compare
|
this is better. for future reference we should not |
|
Sounds good. Yeah, my branch should still be there unmodified. |
interactivellama
added a commit
that referenced
this pull request
May 22, 2015
Tree select bug for 3.7.x branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merged #1283 into master out of order. should have merged to 3.7.x first.