This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Make Marketing Cloud Theme documentation page future compatible #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just got an email this morning from a developer asking why the markup was different between: - http://getfuelux.com/mctheme/index.html#mctheme - http://exacttarget.github.io/fuelux-mctheme/ - http://fuelux-mctheme.herokuapp.com/ Task completed: - Replace fixed version asset links with ambiguous x-range - Update iframes to edge server which has latest markup
|
Template lib and server? |
| <link href="{{site.mctheme.css}}" rel="stylesheet"> | ||
| <link href="//maxcdn.bootstrapcdn.com/bootstrap/3.3.4/css/bootstrap.min.css" rel="stylesheet"> | ||
| <link href="//www.fuelcdn.com/fuelux/3.x.x/css/fuelux.min.css" rel="stylesheet"> | ||
| <link href="//www.fuelcdn.com/fuelux-mctheme/1.x.x/css/fuelux-mctheme.min.css" rel="stylesheet"> |
There was a problem hiding this comment.
http://www.fuelcdn.com/fuelux-mctheme/1/
Should we use this? Has this ftp dir been added to the deployment process?
There was a problem hiding this comment.
No, it's intentionally wrong.
This page is not being updated regularly. MCtheme is still at 1.0.0 and Fuel UX is at 3.6.3.
That's why I added the "Please refer to the repository for the latest release." line.
There was a problem hiding this comment.
I understand better now
swilliamset
pushed a commit
that referenced
this pull request
May 19, 2015
Make Marketing Cloud Theme documentation page future compatible
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just got an email this morning from a developer asking why the markup was different between:
Task completed: