Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Add frozen column support to repeater list view #1223

Conversation

BenjaminNeilDavis
Copy link
Contributor

Creation of new frozen plugin for repeater to fix #1194


//EXTENSION DEFINITION
$.fn.repeater.viewTypes.frozen = {
cleared: function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed altogether unless something will reside within the function

@kevinparkerson
Copy link
Contributor

Looking pretty good! I noticed a few minor issues:

  1. In the dev.html page, the repeater's footer content was extending beyond the footer itself. This appeared to resolve itself when resizing the browser, so it's probably a fluke of the repeater's sizing method, which can be solved by calling "resize" at the appropriate time. Doubt it's due to the plugin, but wanted to make note of it.

  2. In Firefox, the frozen column header is missing a right border. There is also a little wonkiness with the frozen column shifting around a bit.

@BenjaminNeilDavis BenjaminNeilDavis force-pushed the issue-1194-repeater-frozen-column branch from 5080017 to 2690049 Compare April 9, 2015 17:23
@interactivellama interactivellama added this to the 3.7.0 milestone Apr 9, 2015
@@ -202,6 +254,11 @@
self.list_positionHeadings();
}
});
if (self.viewOptions.list_frozenColumns) {
helpers.container.on('scroll.fu.repeaterFrozen', function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This event should be scroll.fu.repeaterList. Probably a symptom of moving code from the repeater-frozen file into the repeater-list plugin

@kevinparkerson
Copy link
Contributor

Commented on the event naming, outside that looks good!

UPDATE: we're going to have to support row selection with frozen columns somehow :|

@BenjaminNeilDavis BenjaminNeilDavis force-pushed the issue-1194-repeater-frozen-column branch 4 times, most recently from 258b0a3 to 0665dc7 Compare April 14, 2015 15:36
…er of the frozen column and required a left position. Otherwise on scroll the frozen column would move how much the table was scrolled.

Removing separate frozen plugin. Integrating frozen columns into repeater-list.

Adding ability to add more than one column that is frozen.

Changed listener based on Kevins catch during review

Fix weird extra characters
@BenjaminNeilDavis BenjaminNeilDavis force-pushed the issue-1194-repeater-frozen-column branch from 3e3c697 to e1bc784 Compare April 14, 2015 16:46
swilliamset pushed a commit that referenced this pull request Apr 14, 2015
…rozen-column

Issue 1194 repeater frozen column
@swilliamset swilliamset merged commit e3f620a into ExactTarget:master Apr 14, 2015
@interactivellama interactivellama changed the title Issue 1194 repeater frozen column Add frozen column support to repeater list view Apr 14, 2015
@BenjaminNeilDavis
Copy link
Contributor Author

To use the frozen columns:

  • Use the list view option list_frozenColumns: n where n is the number of columns to freeze. These must be the columns on the farthest left.
  • The frozen columns table is set to table-layout: fixed; which helps with the sizing of the frozen column and to keep from changing the sizes of the columns between page switches. With this enabled you can set the width of the columns with something like this:
table thead tr th, .repeater-list-heading {
width: 200px;
}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeater Frozen Column
4 participants