-
Notifications
You must be signed in to change notification settings - Fork 1k
Add frozen column support to repeater list view #1223
Add frozen column support to repeater list view #1223
Conversation
|
||
//EXTENSION DEFINITION | ||
$.fn.repeater.viewTypes.frozen = { | ||
cleared: function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be removed altogether unless something will reside within the function
Looking pretty good! I noticed a few minor issues:
|
5080017
to
2690049
Compare
@@ -202,6 +254,11 @@ | |||
self.list_positionHeadings(); | |||
} | |||
}); | |||
if (self.viewOptions.list_frozenColumns) { | |||
helpers.container.on('scroll.fu.repeaterFrozen', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This event should be scroll.fu.repeaterList
. Probably a symptom of moving code from the repeater-frozen file into the repeater-list plugin
Commented on the event naming, outside that looks good! UPDATE: we're going to have to support row selection with frozen columns somehow :| |
258b0a3
to
0665dc7
Compare
…er of the frozen column and required a left position. Otherwise on scroll the frozen column would move how much the table was scrolled. Removing separate frozen plugin. Integrating frozen columns into repeater-list. Adding ability to add more than one column that is frozen. Changed listener based on Kevins catch during review Fix weird extra characters
3e3c697
to
e1bc784
Compare
…rozen-column Issue 1194 repeater frozen column
To use the frozen columns:
|
Creation of new frozen plugin for repeater to fix #1194