Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Remove misc.less, correct checkbox/radio w/o text label style, move placard and select CSS rules #1207

Merged
merged 4 commits into from
Apr 2, 2015

Conversation

interactivellama
Copy link
Contributor

  • Fixes #1196.
  • Removes misc.less and places existing LESS inside control classes to avoid CSS rule collision and play nice with everyone since .fuelux is often applied to the html tag.
  • Added checkbox/radio (no-JS) example within .input-group-addon markup, so we can monitor what that looks like going forward.
  • Made example for inline radio and checkboxes use span, since it may be within a span container and a div within a span is a validation no-no.

I'm going to call this a style breaking change, since if you were using .glass outside of placard then this is going to break that. However, that class was never documented and therefore this isn't a breaking change, and I'm assigning it to a bugfix release.

@swilliamset
Copy link
Contributor

Please keep your PR focused on the issue it is intended to resolve. The refactor of the misc.less file should be another PR especially if there is potential for it to be a breaking change. Please update the branch minus those changes.

chriscorwin added a commit that referenced this pull request Apr 2, 2015
Correct style for checkbox/radio without a text label
@chriscorwin chriscorwin merged commit 0730bec into ExactTarget:master Apr 2, 2015
@interactivellama interactivellama changed the title Correct style for checkbox/radio without a text label Removes misc.less, checkbox/radio without a text label style corrected Apr 3, 2015
@interactivellama interactivellama changed the title Removes misc.less, checkbox/radio without a text label style corrected Remove misc.less, correct checkbox/radio w/o text label style, move placard and select CSS rules Apr 7, 2015
@interactivellama interactivellama deleted the no-label-checkbox branch June 15, 2015 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor misc.less to be less greedy in it's cascade
3 participants