Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Radio button refactor #1195

Merged
merged 6 commits into from
Apr 14, 2015
Merged

Radio button refactor #1195

merged 6 commits into from
Apr 14, 2015

Conversation

mbeard
Copy link
Contributor

@mbeard mbeard commented Mar 25, 2015

Refactor of the radio control.

@swilliamset
Copy link
Contributor

@mbeard please rebase to resolve merge conflict

@swilliamset
Copy link
Contributor

@sjames include undocumented methods no longer available in the release notes

@interactivellama
Copy link
Contributor

The following undocumented public methods have been removed from radio:
setState, toggleContainer

Additionally, the radio and checkbox controls are now bound to the parent element with the respective .radio and .checkbox classes and no longer to the <input> element.

@mbeard Anything else that you would like to see in the release notes?

@interactivellama interactivellama changed the title refactoring of radio button Radio refactor Apr 11, 2015
@interactivellama interactivellama changed the title Radio refactor Radio Button refactor Apr 11, 2015
@interactivellama interactivellama changed the title Radio Button refactor Radio button refactor Apr 11, 2015
@chriscorwin
Copy link
Contributor

Went to review this, there's significant diffs from the latest master.

@mbeard can you pull latest from upstream and merge master in then re-submit this?

@mbeard
Copy link
Contributor Author

mbeard commented Apr 13, 2015

@chriscorwin done

@chriscorwin
Copy link
Contributor

Cool... except now the radio highlighting isn't working, similar to how checkbox isn't in its branch.

I have tweaked the rules, and uploaded what radio.less should be to a gist, here:

https://gist.github.com/chriscorwin/63ef5e32609ef677c2ef

Put that into place and I think we're golden.

@chriscorwin chriscorwin assigned mbeard and unassigned chriscorwin Apr 14, 2015
@chriscorwin chriscorwin assigned chriscorwin and unassigned mbeard Apr 14, 2015
chriscorwin added a commit that referenced this pull request Apr 14, 2015
@chriscorwin chriscorwin merged commit 92a32f8 into ExactTarget:master Apr 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants